Patch for bug #61660 #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the hexadecimal string has an odd length, the resulting binary data must be left padded with 0s in order to be aligned on 8 bits. To avoid extraneous if test on each iteration, we distinguish the special case by pointing the source data iterator the the NUL bytes at the end which we can then detect and act accordingly.
|
I changed the comment style and reverted the encoding problems. BTW the encoding problem was coming from the github inline editor since I did my first patch through the web interface. |
|
I'll redo the pull request cleanly. |
nikic
pushed a commit
to nikic/php-src
that referenced
this pull request
Jan 20, 2013
php-pulls
pushed a commit
that referenced
this pull request
Dec 20, 2013
In english, no horizontal space before “!”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch for : https://bugs.php.net/bug.php?id=61660
I'm the one who reported the bug and I tested the patch in the particular case which led to his discovery.
Their can still be a problem with
bin2hex. The reverse function is not aware of left padded values and thus return '01234' for example which can lead to some problems like stated by laruence in the bug comments.I think
bin2hexshould also be patched to remove any leading 0s in the binary representation before converting it, but this is out of the scope of my patch and needs discussion.